Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the embed function to support creating embeddings from text or image data in BigQuery. The implementation includes the core operation logic, integration with Ibis and SQLGlot compilers, and comprehensive unit tests. Feedback was provided to correct the type hint for connection_id, optimize the parameter validation logic using a generator expression, and fix a docstring copy-paste error in the vendored Ibis operations.
sycai
force-pushed
the
sycai_ai_embed
branch
2 times, most recently
from
75fda1f to
d225c0c
Compare
|
Pre-release tests failed at |
sycai
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
|
||
| @log_adapter.method_logger(custom_base_name="bigquery_ai") | ||
| def embed( | ||
| content: str | series.Series | pd.Series, |
There was a problem hiding this comment.
Don't need to in this PR, but would nice to get all these working with the pd.col expression interface, and maybe (single-level) index values as well? Maybe we define "column-value" types and a common adapter, type annotation
There was a problem hiding this comment.
Sounds good to me. Opened b/507096491 to track this FR
3 participants
Fixes b/497836685 🦕